Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscroll container with height: 100% #271

Closed
jgerigmeyer opened this issue Feb 10, 2015 · 8 comments
Closed

Autoscroll container with height: 100% #271

jgerigmeyer opened this issue Feb 10, 2015 · 8 comments
Labels
enhancement Quality of life changes to existing features
Milestone

Comments

@jgerigmeyer
Copy link

On touch, when trying to scroll a container set to height: 100% and the window isn't scrollable, autoscroll doesn't work. Because the drag is at the edge of both the container and the window, I think the plugin is trying to scroll the window instead of the scrollable container. If I comment out lines 424-426 (https://github.com/RubaXa/Sortable/blob/master/Sortable.js#L424-426) to force the plugin to scroll the scrollable container instead, that fixes it.

http://codepen.io/jgerigmeyer/pen/PwEWQM

Any suggestions? Am I doing something wrong?

@RubaXa RubaXa added the enhancement Quality of life changes to existing features label Feb 10, 2015
RubaXa added a commit that referenced this issue Feb 10, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 10, 2015

Try scroll-branch.

@jgerigmeyer
Copy link
Author

Fixed, thanks! Can't wait for this to get merged into a new release. 👍

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

1-2 weeks

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

If there are no problems, then I'll add it into dev.

@RubaXa RubaXa added this to the v1.1.0 milestone Feb 11, 2015
@lucaperret
Copy link

After sorting, Scrollbar is behind elements. I tried the dev branch, same problem;
http://jsbin.com/cecilozeha/1/

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

@lucaperret In fact, this is a bug of Chrome, but I fixed: http://jsbin.com/vesiwepavi/1/edit

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 12, 2015

@lucaperret ⬆️ ??? ⬆️

@lucaperret
Copy link

Thank you this fix the problem!

@RubaXa RubaXa closed this as completed Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Quality of life changes to existing features
Projects
None yet
Development

No branches or pull requests

3 participants