Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "emulate drag over" with nested web components #1371

Closed
wants to merge 3 commits into from

Conversation

yorrd
Copy link

@yorrd yorrd commented Oct 2, 2018

No description provided.

@owen-m1
Copy link
Member

owen-m1 commented Nov 16, 2018

What issue does this solve, more specifically?

@yorrd
Copy link
Author

yorrd commented Nov 16, 2018

What issue does this solve, more specifically?

When you have several nested web components, the changed code would only find the outer one instead of the inner one (which is the desired behavior).

Does this make sense?

@owen-m1
Copy link
Member

owen-m1 commented Nov 16, 2018

I would appreciate it if you created a jsfiddle or jsbin demonstrating this. I do not fully understand the solution. For example, I do not think your code would work if the target element did not have a shadowRoot.

@yorrd
Copy link
Author

yorrd commented Nov 17, 2018

Let me get back to you when I'm home in a few days!

@owen-m1
Copy link
Member

owen-m1 commented Dec 15, 2018

@yorrd Is this still relevant?

@yorrd
Copy link
Author

yorrd commented Dec 16, 2018

@owen-m1 im sorry. It is, but feel free to close it if you want to clean up. If I get around to investigating this again, I'll reopen and add information. The thing is, it's working for us and the year is coming to an end so time is tight ;)

@thomascavalli
Copy link

@owen-m1 please see https://jsfiddle.net/ahdzvnu6/1/ this is related to issue #1489

Thanks

@owen-m1
Copy link
Member

owen-m1 commented Apr 17, 2019

@thomascavalli Your demo loaded for me yesterday but now it gives 404 errors. Please fix this and I can have a look.

@thomascavalli
Copy link

@owen-m1 let's try jsbin: https://jsbin.com/hunukuy

@owen-m1
Copy link
Member

owen-m1 commented Apr 18, 2019

@thomascavalli Try master branch

@owen-m1 owen-m1 closed this Apr 19, 2019
@thomascavalli
Copy link

@owen-m1 Perfect, thanks! https://jsbin.com/kozusop

Is there a release cycle to know when to expect the updated code to be available in a specific version number? I came across this issue via SortableJS/Vue.Draggable, so this is actually a nested dependency in my project and not pulled in from an external host at this point.

@owen-m1
Copy link
Member

owen-m1 commented Apr 19, 2019

@thomascavalli I will release 1.8.5 tomorrow

@owen-m1
Copy link
Member

owen-m1 commented Apr 20, 2019

@thomascavalli 1.9.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants