-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "emulate drag over" with nested web components #1371
Conversation
What issue does this solve, more specifically? |
When you have several nested web components, the changed code would only find the outer one instead of the inner one (which is the desired behavior). Does this make sense? |
I would appreciate it if you created a jsfiddle or jsbin demonstrating this. I do not fully understand the solution. For example, I do not think your code would work if the target element did not have a |
Let me get back to you when I'm home in a few days! |
@yorrd Is this still relevant? |
@owen-m1 im sorry. It is, but feel free to close it if you want to clean up. If I get around to investigating this again, I'll reopen and add information. The thing is, it's working for us and the year is coming to an end so time is tight ;) |
@owen-m1 please see https://jsfiddle.net/ahdzvnu6/1/ this is related to issue #1489 Thanks |
@thomascavalli Your demo loaded for me yesterday but now it gives 404 errors. Please fix this and I can have a look. |
@owen-m1 let's try jsbin: https://jsbin.com/hunukuy |
@thomascavalli Try |
@owen-m1 Perfect, thanks! https://jsbin.com/kozusop Is there a release cycle to know when to expect the updated code to be available in a specific version number? I came across this issue via SortableJS/Vue.Draggable, so this is actually a nested dependency in my project and not pulled in from an external host at this point. |
@thomascavalli I will release 1.8.5 tomorrow |
@thomascavalli |
No description provided.