Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in new chrome browser #41

Closed
kostiantyn-solianyk opened this issue Nov 18, 2017 · 11 comments
Closed

Doesn't work in new chrome browser #41

kostiantyn-solianyk opened this issue Nov 18, 2017 · 11 comments

Comments

@kostiantyn-solianyk
Copy link

kostiantyn-solianyk commented Nov 18, 2017

Works fine in old chrome browser, in new version doesn't work. Nothing heppening. Tested it in lots of Laptops and so. Looks like onChange doesn't work

@kostiantyn-solianyk kostiantyn-solianyk changed the title Doesn't not work in new chrome browser Doesn't work in new chrome browser Nov 18, 2017
@iamraffe
Copy link

iamraffe commented Nov 18, 2017

Having the same issue.

Tested with Firefox 57 & Chrome Version 62.0.3202.94. Both 64-bit

EDIT: Added Firefox occurrence & versions.

@turnerniles
Copy link
Contributor

@iamraffe @kostiantyn-solianyk Is there any error in console? It's working for me on Mac 64-bit Firefox 57 and Chrome 62.0.3202.75. Does the demo not work for you?

@iamraffe
Copy link

@turnerniles no errors on console. It's just as if the drag event isn't recorded/doesn't start.

Stopped working all of the sudden for a site that's been in production for about 18-24 months.

Also I tested using Ubuntu with those versions. Tested on Mac (wasn't working either) but didn't write down the version number.

Went back to Version 59.0.3071.115 on Chrome and it is working perfectly.

I can test the demo tomorrow, also record a video if that would help.

@turnerniles
Copy link
Contributor

@iamraffe @kostiantyn-solianyk @cheton Looks like this is a RubaXa sortable bug. #1182 #1213 #1199. I think we should update RubaXa sortable to 1.6.1 as it seems there are still issues with 1.7.0 and 1.7.1 according to the threads.

@iamraffe
Copy link

@turnerniles anything we can do to help? I'm not sure what updating to 1.6.1 would entail to be honest.

@turnerniles
Copy link
Contributor

@iamraffe I can raise a PR for @cheton to review tonight. I don't believe any other changes will be needed aside from updating the dependency.

@iamraffe
Copy link

@turnerniles great!

@turnerniles
Copy link
Contributor

I've created a PR #42. @cheton could you please review?

@cheton
Copy link
Collaborator

cheton commented Nov 21, 2017

If the issue still exists with sortablejs 1.7.x, you can use a specific version (i.e. without ^) of sortablejs in your package.json as a temporary workaround until it's getting fixed:

"dependencies": {
    "sortablejs": "1.6.1",
    "react-sortablejs": "^1.3.6"
}

@kostiantyn-solianyk
Copy link
Author

Thanks! @turnerniles @iamraffe @cheton Sorry, I was busy, could not join the conversation, with new dependencies everything works fine, and everywhere.

@iamraffe
Copy link

Yeah I just deployed and it seems to be working again across the board. Will update if anything weird happens, but I think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants