fix: Add another mounted check #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've got this in the app: 11-16 13:08:12.526 30218 30261 E flutter : [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: NoSuchMethodError: The method 'markNeedsBuild' was called on null. 11-16 13:08:12.526 30218 30261 E flutter : Receiver: null 11-16 13:08:12.526 30218 30261 E flutter : Tried calling: markNeedsBuild() 11-16 13:08:12.526 30218 30261 E flutter : #0 State.setState (package:flutter/src/widgets/framework.dart:1264) 11-16 13:08:12.526 30218 30261 E flutter : #1 _CodeBlockState.initState.<anonymous closure>.<anonymous closure> (package:flutter_matrix_html/code_block.dart:62) 11-16 13:08:12.526 30218 30261 E flutter : #2 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1117) 11-16 13:08:12.526 30218 30261 E flutter : #3 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1063) 11-16 13:08:12.526 30218 30261 E flutter : #4 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:971) 11-16 13:08:12.526 30218 30261 E flutter : #5 _rootRun (dart:async/zone.dart:1190) 11-16 13:08:12.526 30218 30261 E flutter : #6 _CustomZone.run (dart:async/zone.dart:1093) 11-16 13:08:12.526 30218 30261 E flutter : #7 _CustomZone.runGuarded (dart:async/zone.dart:997) 11-16 13:08:12.526 30218 30261 E flutter : #8 _invoke (dart:ui/hooks.dart:251) 11-16 13:08:12.526 30218 30261 E flutter : #9 _drawFrame (dart:ui/hooks.dart:209) So I guess we need a mounted check there too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got this in the app:
11-16 13:08:12.526 30218 30261 E flutter : [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: NoSuchMethodError: The method 'markNeedsBuild' was called on null.
11-16 13:08:12.526 30218 30261 E flutter : Receiver: null
11-16 13:08:12.526 30218 30261 E flutter : Tried calling: markNeedsBuild()
11-16 13:08:12.526 30218 30261 E flutter : #0 State.setState (package:flutter/src/widgets/framework.dart:1264)
11-16 13:08:12.526 30218 30261 E flutter : #1 _CodeBlockState.initState.. (package:flutter_matrix_html/code_block.dart:62)
11-16 13:08:12.526 30218 30261 E flutter : #2 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1117)
11-16 13:08:12.526 30218 30261 E flutter : #3 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1063)
11-16 13:08:12.526 30218 30261 E flutter : #4 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:971)
11-16 13:08:12.526 30218 30261 E flutter : #5 _rootRun (dart:async/zone.dart:1190)
11-16 13:08:12.526 30218 30261 E flutter : #6 _CustomZone.run (dart:async/zone.dart:1093)
11-16 13:08:12.526 30218 30261 E flutter : #7 _CustomZone.runGuarded (dart:async/zone.dart:997)
11-16 13:08:12.526 30218 30261 E flutter : #8 _invoke (dart:ui/hooks.dart:251)
11-16 13:08:12.526 30218 30261 E flutter : #9 _drawFrame (dart:ui/hooks.dart:209)
So I guess we need a mounted check there too.