improve/add pill builder for customization #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
force-pushed
the
improve/add-customize-pill-builder
branch
2 times, most recently
from
ba3a3cc
to
831af80
Compare
sherlockvn
force-pushed
the
improve/add-customize-pill-builder
branch
from
831af80
to
7fa0a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Sorunome, I would like to make a change to your package because the current Pill widget uses FutureBuilder, which causes the message to be rebuilt multiple times and results in a blink effect. My solution is to cache the
PillInfooutside of the widget and avoid using FutureBuilder internally. Additionally, I believe that the current customization options for the Pill widget are quite limited.Screen.Recording.2023-07-03.at.14.16.03.mov
Screen.Recording.2023-07-03.at.14.16.47.mov