Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old config file not working for me after update #106

Open
Impr0ve opened this issue Feb 3, 2022 · 7 comments
Open

Old config file not working for me after update #106

Impr0ve opened this issue Feb 3, 2022 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Impr0ve
Copy link

Impr0ve commented Feb 3, 2022

I just found out you guys were keeping this project going and I updated it and now my old rune configs aren't loading
is anybody else having this issue?

@Soundofdarkness
Copy link
Owner

Hey !
Im pretty sure we did change parts of the config format at some point, so that most likely broke it. If you are able to attach your config here I can try to take a look if I can get it to load in some way again.
(Path should be %appdata%\Runebook\config.json )

@Impr0ve
Copy link
Author

Impr0ve commented Feb 5, 2022

Ok thanks for that I thought It might be the format I just don't know enough to figure it out had to change it to .txt cause it wouldn't allow json files
config.txt
t

@Soundofdarkness
Copy link
Owner

Aight, checked it for a short time so far, seems like a few of the rune pages error out when they get prepared for the format the league client wants, I will tinker with it the next days and see if I can convert them, but that might take a while, sorry.

@Impr0ve
Copy link
Author

Impr0ve commented Feb 9, 2022

Ok, thank you! I wish I could help but I don't know how to code :( would be easy to make a program that can convert the config
so in case, anybody else has this issue?

@Soundofdarkness
Copy link
Owner

Dont worry, it was happily not hard after I found out what the problem was. (back then some pages just stored the perk-id's as text instead of as number). I theoretically have a tool that can convert them now, but since the code is just thrown together I wont publish it unless more people need it I think, since I would have to clean it up quite a bit first.
But I think your file should work now, but tell me if you see any issues ! (only problem is that there might be a few pages where you cant sync them anymore since the plugin doesnt exist anymore, but not sure)
config.txt

@Impr0ve
Copy link
Author

Impr0ve commented Feb 14, 2022

Awesome it works! yea the sync thing broken but it's OK, I don't really need that anyways thanks again for helping me out :)

@Soundofdarkness
Copy link
Owner

No problem! Nice to hear it works fine!
Im going to keep this issue open for the time being in case more people have the same issue, just in case.

@Soundofdarkness Soundofdarkness added the documentation Improvements or additions to documentation label Feb 15, 2022
@Soundofdarkness Soundofdarkness self-assigned this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants