-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Leak in current master branch #118
Comments
Alright, found the issue I think. Seems like accessing the freezer for bigger objects inside tags causes it. (In this case itemsinfo) Edit again: Ram issue is back suddenly, no idea why but it seems like what I thought at first is wrong. Unfortunately I don't have more time today, so I'm probably going to continue looking into this in the next days. |
I took a quick look at it and I couldn't really reproduce it, yeah RuneBook uses a bit more when different pages get loaded but nowhere near a gig. Maybe its because I'm on Linux or so I don't know. Anyways I will take a deeper look at it during the weekend |
I can confirm it happened to me too (twice), but I didn't investigate it further. |
It could be a problem with |
True, I could put some time into updating everything but I can't confirm that I didn't in fact introduce this myself. |
But there are bugs in the item explorer in general (since I don't use it I didn't deal with it).
The console is spammed with: Cannot read property 'start_items' of undefined Maybe there is an error here. Btw. I'm thinking about rewriting Runebook in C# this whole Electron/JS crap is just not mine^^ |
Yeah that's because I messed up an if statement in page-list it needs to be if={page.name == "bltitzgg" || page.name == "opgg"} and what's currently is^^ and sounds doable but it will take you a lot of time |
I'm personally guessing its something related to RiotJS too, as I've tried storing the items data in localstorage instead of the freezer, but still had the same problem. Problem with RiotJS is that they dont recommend migrating from v3 to higher versions since 3.x is still maintained according to them (seems like they changed quite a bit from v3 to v6). @Rerago Problem with C# is just going to be cross platform UI, since iirc there is still just Avalonia. Not sure if that works well enough or not. Aside from that it sounds like an idea, just going to be a ton of work. |
Okay, thanks for the information while I would like to work on an update I can't because my finals are coming up :/ But in around 35 Days I would be able to take a look at it again if nobody updated to a newer version by then. |
Sounds good and don’t worry ! Finals are way more important, take all the time you need. I’m still looking into it too in my free time, but since I have a lot of health stuff going on in my family I’m limited too. |
Alright, |
Okay, I quickly tested it again too, now it seems to work for me too. |
@HannoMartinus Since you had the issue too at some point: Would you maybe be able to check if the issue persists for you ? |
Okay, now I had the bug yet again, but it seems like it only happens with dev tools open ? Which could actually make sense since it seems to try to inspect that 1MB json from op.gg and that even multiple times, so maybe thats just something it can't deal with. |
Seems that we currently have a memory leak happening when swapping away from a page with an item set button.
I haven't found any obvious cause, so far, I just hope its not some internal electron bug as it seems to not be disposing of state correctly.
(Just going to move this from PR #117 to here, in case somebody has an idea)
The text was updated successfully, but these errors were encountered: