-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opgg add item sets #117
Opgg add item sets #117
Conversation
Looks good ! Going to merge this now and I will try to release the update today if possible. |
Thanks for merging, I'm in the middle of a lol game but I saw that I messed up with this PR because forgot to correct an if statement grrr. |
Yep, I've already fixed that in local, just need to push it with the version bump, dont worry ^^
|
Okay actually, we need to wait with the release since somewhere within the op.gg plugin we seem to use somewhere around 700MB to load pages (at least for Lux, havent checked other champions), so we currently spike to around 1GB ram usage. Im going to try to take a look whats happening there, but that might take a bit. |
Moved the problem to #118 so its easier to find. |
Adds item sets from op.gg, merge after #116 or else it will have conflicts