Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opgg add item sets #117

Merged
merged 11 commits into from
Mar 17, 2022
Merged

Conversation

89Q12
Copy link

@89Q12 89Q12 commented Mar 13, 2022

Adds item sets from op.gg, merge after #116 or else it will have conflicts

@Soundofdarkness
Copy link
Owner

Looks good ! Going to merge this now and I will try to release the update today if possible.
Thank you !

@Soundofdarkness Soundofdarkness merged commit 889ff90 into Soundofdarkness:master Mar 17, 2022
@89Q12
Copy link
Author

89Q12 commented Mar 17, 2022

Thanks for merging, I'm in the middle of a lol game but I saw that I messed up with this PR because forgot to correct an if statement grrr.
In the tag page-list the if statement needs to be if={opts.tab.active == "blitzgg" || opts.tab.active "opgg"} and not f={opts.tab.active == "blitzgg" || "opgg"} maybe you could change it before you release it. Because otherwise the item set button will be shown on every page which is miss leading.

@Soundofdarkness
Copy link
Owner

Yep, I've already fixed that in local, just need to push it with the version bump, dont worry ^^
Just currently trying to figure out why I seem to have some performance issues with that build, but that might be something non-fixable in the short term.

  • I need to temporarily disable MetaSRC due to not working and presumably leaking memory due to a redirect loop.

@Soundofdarkness
Copy link
Owner

Soundofdarkness commented Mar 17, 2022

Okay actually, we need to wait with the release since somewhere within the op.gg plugin we seem to use somewhere around 700MB to load pages (at least for Lux, havent checked other champions), so we currently spike to around 1GB ram usage. Im going to try to take a look whats happening there, but that might take a bit.
Edit: Doesn't specifically seem to trigger on the op.gg plugin, but rather when switching away from a page with the builds modal, so I have 0 clue what causes it so far. (seems to be around 700MB each time when swapping away from any page with an item set)

@Soundofdarkness
Copy link
Owner

Moved the problem to #118 so its easier to find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants