Some improvements

Reset settings when clicking cancel (fixes #7)
Make volume sliders clickable (fixes #9)
Extend some labels (fixes #10)
Created own component for SoundListWidgetItem (fixes #11)
Add a clear button to the SetHotkeyDialog (fixes #14)

README.md

@@ -68,7 +68,7 @@ This list may be not accurate. Contact me if you find missing dependencies that
 
 ### Install dependencies for Ubuntu and derivatives (Thanks to @Tibladar)
 ```sh
-sudo apt install git go qt5-default libqt5x11extras5-dev mpg123
+sudo apt install git golang-go qt5-default libqt5x11extras5-dev mpg123
 go get qpm.io/qpm
 ```
 

Soundboard.pro

@@ -19,6 +19,7 @@ include(vendor/de/skycoder42/qhotkey/qhotkey.pri)
 
 SOURCES += \
     RunGuard.cpp \
+    soundlistwidgetitem.cpp \
     soundplayback.cpp \
     customkeysequenceedit.cpp \
     main.cpp \
@@ -30,6 +31,8 @@ SOURCES += \
 
 HEADERS += \
     RunGuard.h \
+    clickablesliderstyle.h \
+    soundlistwidgetitem.h \
     soundplayback.h \
     customkeysequenceedit.h \
     mainwindow.h \
@@ -43,7 +46,8 @@ FORMS += \
     mainwindow.ui
 
 RESOURCES += \
-    resources.qrc
+    resources.qrc \
+    qdarkstyle/style.qrc
 
 # Default rules for deployment.
 qnx: target.path = /tmp/$${TARGET}/bin

clickablesliderstyle.h

@@ -0,0 +1,22 @@
+#ifndef CLICKABLESLIDERSTYLE_H
+#define CLICKABLESLIDERSTYLE_H
+
+#include <QObject>
+#include <QProxyStyle>
+
+// Thanks to https://stackoverflow.com/a/26281608
+class ClickableSliderStyle : public QProxyStyle
+{
+public:
+    using QProxyStyle::QProxyStyle;
+
+    int styleHint(QStyle::StyleHint hint, const QStyleOption* option = nullptr, const QWidget* widget = nullptr, QStyleHintReturn* returnData = nullptr) const
+    {
+        if (hint == QStyle::SH_Slider_AbsoluteSetButtons)
+            return (Qt::LeftButton | Qt::MidButton | Qt::RightButton);
+        return QProxyStyle::styleHint(hint, option, widget, returnData);
+    }
+
+};
+
+#endif // CLICKABLESLIDERSTYLE_H

mainwindow.cpp

@@ -20,6 +20,9 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new Ui::MainWi
     ui->tabWidget->setMovable(true);
     ui->stopButton->setDisabled(true);
 
+    ui->remoteVolumeSlider->setStyle(new ClickableSliderStyle(ui->remoteVolumeSlider->style()));
+    ui->localVolumeSlider->setStyle(new ClickableSliderStyle(ui->localVolumeSlider->style()));
+
     // Set the config variables
     configFolder = QStandardPaths::standardLocations(QStandardPaths::ConfigLocation)[0].toStdString() + "/" + windowTitle().toStdString();
     if (!filesystem::exists(configFolder))
@@ -203,7 +206,7 @@ void MainWindow::addSoundToView(QFile &file, QListWidget *widget)
         }
     }
 
-    auto item = new QListWidgetItem();
+    auto item = new SoundListWidgetItem();
     item->setText(fileInfo.baseName());
     item->setToolTip(fileInfo.absoluteFilePath());
     widget->addItem(item);
@@ -244,9 +247,10 @@ void MainWindow::on_removeSoundButton_clicked()
 {
     if (getActiveView())
     {
-        QListWidgetItem *it = getActiveView()->takeItem(getActiveView()->currentRow());
+        SoundListWidgetItem *it = getSelectedItem();
         if (it)
         {
+            unregisterHotkey(it);
             delete it;
             saveSoundFiles();
         }
@@ -266,18 +270,18 @@ void MainWindow::on_clearSoundsButton_clicked()
     }
 }
 
-QListWidgetItem *MainWindow::getSelectedItem()
+SoundListWidgetItem *MainWindow::getSelectedItem()
 {
     if (getActiveView())
     {
-        return getActiveView()->item(getActiveView()->currentRow());
+        return (SoundListWidgetItem*) getActiveView()->item(getActiveView()->currentRow());
     }
     return nullptr;
 }
 
 void MainWindow::on_playSoundButton_clicked()
 {
-    QListWidgetItem *it = getActiveView()->item(getActiveView()->currentRow());
+    SoundListWidgetItem *it = getSelectedItem();
     if (it)
     {
         soundPlayback->playSound(it->toolTip().toStdString());
@@ -297,14 +301,14 @@ void MainWindow::on_addTabButton_clicked()
 
 void MainWindow::on_setHotkeyButton_clicked()
 {
-    QListWidgetItem *it = getActiveView()->item(getActiveView()->currentRow());
+    SoundListWidgetItem *it = getSelectedItem();
     if (it)
     {
         SetHotkeyDialog shd(this, it);
         shd.exec();
 
-        if (!it->data(1).isNull()) {
-            registerHotkey(it, it->data(1).toString());
+        if (!it->hotkey.isNull()) {
+            registerHotkey(it, it->hotkey.toString());
         } else {
             unregisterHotkey(it);
         }
@@ -313,12 +317,12 @@ void MainWindow::on_setHotkeyButton_clicked()
     }
 }
 
-void MainWindow::registerHotkey(QListWidgetItem* it, QString keys)
+void MainWindow::registerHotkey(SoundListWidgetItem* it, QString keys)
 {
     // Unregister previous hotkey
     unregisterHotkey(it);
 
-    it->setData(1, keys);
+    it->setHotkey(keys);
     auto neger = QKeySequence(keys);
 
     auto hotkey = new QHotkey(QKeySequence(keys), true, this);
@@ -353,9 +357,9 @@ bool caseInSensStringCompare(string &str1, string &str2)
             equal(str1.begin(), str1.end(), str2.begin(), &compareChar));
 }
 
-void MainWindow::unregisterHotkey(QListWidgetItem *it)
+void MainWindow::unregisterHotkey(SoundListWidgetItem *it)
 {
-    auto previousHotkey = it->data(1);
+    auto previousHotkey = it->hotkey;
     if (!previousHotkey.isNull())
     {
         auto previousHotkeyStr = previousHotkey.toString().toStdString();
@@ -370,7 +374,7 @@ void MainWindow::unregisterHotkey(QListWidgetItem *it)
         }
 
         // Reset Data
-        it->setData(1, QVariant());
+        it->setHotkey(QVariant());
     }
 }
 
@@ -432,16 +436,17 @@ void MainWindow::saveSoundFiles()
         json tabJson;
         json tabJsonSounds = json::array();
 
-        for (QListWidgetItem *item : listWidget->findItems("*", Qt::MatchWildcard))
+        for (auto *_item : listWidget->findItems("*", Qt::MatchWildcard))
         {
+            auto item = (SoundListWidgetItem*) _item;
             json j;
             j["name"] = item->text().toStdString();
             j["path"] = item->toolTip().toStdString();
 
-            auto hotkey = item->data(1);
+            auto hotkey = item->hotkey;
             if (!hotkey.isNull())
             {
-                auto hotkeyStr = item->data(1).toString().toStdString();
+                auto hotkeyStr = hotkey.toString().toStdString();
                 j["hotkey"] = hotkeyStr;
             }
 
@@ -483,7 +488,7 @@ void MainWindow::loadSoundFiles()
                     auto soundPath = _child["path"];
                     remove(soundPath.begin(), soundPath.end(), '"');
 
-                    auto item = new QListWidgetItem();
+                    auto item = new SoundListWidgetItem();
                     item->setText(QString::fromStdString(soundName));
                     item->setToolTip(QString::fromStdString(soundPath));
 

mainwindow.h

@@ -34,6 +34,8 @@
 #include <soundplayback.h>
 #include <settings.h>
 #include <sethotkeydialog.h>
+#include <clickablesliderstyle.h>
+#include <soundlistwidgetitem.h>
 
 class SoundPlayback;
 class SettingsDialog;
@@ -66,12 +68,12 @@ class MainWindow : public QMainWindow
     void saveSoundFiles();
     void loadSoundFiles();
     QListWidget *getActiveView();
-    QListWidgetItem *getSelectedItem();
+    SoundListWidgetItem *getSelectedItem();
     QListWidget *createTab(QString title);
     void addSoundToView(QFile &file, QListWidget *widget);
     void syncVolume(bool remote);
-    void registerHotkey(QListWidgetItem* it, QString keys);
-    void unregisterHotkey(QListWidgetItem* it);
+    void registerHotkey(SoundListWidgetItem* it, QString keys);
+    void unregisterHotkey(SoundListWidgetItem* it);
 
 private slots:
     void on_addTabButton_clicked();

mainwindow.ui

@@ -54,7 +54,7 @@
      <rect>
       <x>640</x>
       <y>14</y>
-      <width>121</width>
+      <width>131</width>
       <height>20</height>
      </rect>
     </property>
@@ -210,7 +210,7 @@
      <rect>
       <x>175</x>
       <y>90</y>
-      <width>91</width>
+      <width>101</width>
       <height>21</height>
      </rect>
     </property>
@@ -291,7 +291,8 @@
      <string>Set Hotkey</string>
     </property>
     <property name="icon">
-     <iconset theme="input-keyboard-symbolic"/>
+     <iconset theme="input-keyboard-symbolic">
+      <normaloff>.</normaloff>.</iconset>
     </property>
    </widget>
    <widget class="QPushButton" name="settingsButton">
@@ -307,15 +308,16 @@
      <string>Settings</string>
     </property>
     <property name="icon">
-     <iconset theme="preferences-system-symbolic"/>
+     <iconset theme="preferences-system-symbolic">
+      <normaloff>.</normaloff>.</iconset>
     </property>
    </widget>
    <widget class="QLabel" name="remoteVolumeLabel">
     <property name="geometry">
      <rect>
       <x>175</x>
       <y>120</y>
-      <width>101</width>
+      <width>111</width>
       <height>21</height>
      </rect>
     </property>
@@ -355,7 +357,11 @@
      <string>Sync</string>
     </property>
     <property name="icon">
-     <iconset theme="insert-link-symbolic"/>
+     <iconset theme="insert-link-symbolic">
+      <normaloff>.</normaloff>.</iconset>
+    </property>
+    <property name="checked">
+     <bool>true</bool>
     </property>
    </widget>
   </widget>