Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed strong reference of OnError #136

Merged
merged 4 commits into from
May 8, 2020
Merged

Conversation

vilasma
Copy link
Contributor

@vilasma vilasma commented May 4, 2020

Removed strong reference of OnError, onwards passing error in completion handler also removed shared instance of Connectivity Manager. updated unit test cases for the same.

@vilasma vilasma self-assigned this May 4, 2020
@vilasma vilasma merged commit 7549a5a into develop May 8, 2020
@vilasma vilasma deleted the sp-3468_remove_retain_cycle branch May 8, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants