DIA-2193 generate USPString client side #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevazhnovu
requested changes
Jun 6, 2023
| @@ -4,6 +4,7 @@ | |||
| // | |||
| // Created by Andre Herculano on 08.02.21. | |||
| // | |||
| // swiftlint:disable line_length | |||
There was a problem hiding this comment.
Have you checked if it is possible to remove this ignore-linter line and fix the issue itself? Usually, line length is easy to fix.
ConsentViewController/Classes/SourcePointClient/SourcepointClientCoordinator.swift
Outdated
Show resolved
Hide resolved
|
@andresilveirah I would expect to see a little bit more unit tests for this feature ✌️ |
|
@Nevazhnovu just bringing the convo from slack here: |
andresilveirah
commented
Jun 6, 2023
ConsentViewController/Classes/SourcePointClient/ConsentStatusMetadata.swift
Show resolved
Hide resolved
Nevazhnovu
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDKs use to rely on the uspstring returned by the endpoints. However, the uspstring is dependent on ccpa.applies and there are cases in which ccpa.applies changes and the SDK doesn't necessarily need to call the endpoints that return uspstring.
With this PR, the SDK is now generating the uspstring with the data it has locally. If ccpa.applies changes, even if the SDK doesn't receive a new uspstring, it'll now be able to reflect the correct uspstring by generating it on the fly.