Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HCD 516] Add default language precedence #570

Merged
merged 3 commits into from May 13, 2024
Merged

[HCD 516] Add default language precedence #570

merged 3 commits into from May 13, 2024

Conversation

tom-win87
Copy link
Collaborator

No description provided.

@andresilveirah
Copy link
Member

andresilveirah commented May 7, 2024 •
edited

@tom-win87

the user's browser language will always take precedence over the language set in the SDK

It's a bit stronger than that, if the user browser default is set, the language set in the SDK is ignored and the browser's language will be used instead, if that is not supported, the default language is used as a fallback.

What I mean to say is, user browser default not only takes precedence, but causes the rendering app to completely ignore SDK setting.

@tom-win87
Copy link
Collaborator Author

@andresilveirah Thank you for the clarification. I've updated the note using the stronger language

@andresilveirah andresilveirah merged commit 2d6bd11 into develop May 13, 2024
7 checks passed
@andresilveirah andresilveirah deleted the tom-win87-patch-1 branch May 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresilveirah andresilveirah Awaiting requested review from andresilveirah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tom-win87 @andresilveirah