-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as: Deal with CUDA 11.0, "Support for Kepler 'sm_30' and 'sm_32' architecture based products is dropped" #33
Conversation
…itecture based products is dropped" This resolves #30 "[RFC] Handle sm_* which is no longer supported by CUDA / ptxas exec check or configure check?". Suggested-by: Tom de Vries <tdevries@suse.de>
I dislike the silent, unconditional overriding of the
Thus, I think this patch is okay (with a -v warning), but it does not replace the PR #31. @vries – thoughts on this/Thomas' patch and on my comment? |
See also https://gcc.gnu.org/pipermail/gcc-patches/2022-April/593057.html related to this patch: |
Hm, so what would this warning look like? Something like this: I suppose a warning would suggest to an unsuspecting user that some action may need to be taken, which is not the case (because the overriding is unconditional), so perhaps just an informative message, like a note: |
(...)
Fine with me, but maybe "note: using sm_35 to verify sm_30/sm_32 code for CUDA-compatibility reasons" or something like that which gives at least a hint why that's necessary. In the issue itself, #30, a variant of using PTX Compiler APIs instead of ptxas is discussed. Thus, the message could be adapted accordingly, when knowing for sure which sm_xx is actually supported. |
The focus for current nvptx-tools should be to make things work best with current GCC and CUDA versions, and the proposed method (whether it's in GCC or nvptx-tools) seems like an acceptable "degradation" to me. (I'm essentially just moving @vries' GCC-level "workaround: verify using sm_35 when misa=sm_30 is specified" from GCC into nvptx-tools.)
As @vries also said, let's call this a diagnostic/message/note instead of a warning. I'll look into implementing that, but it has to wait until after my upcoming vacations.
I'm not sure I understand what exactly you're implying with "patch disables Thus, the following proposed wording:
... may also not completely true/clear, or maybe even confusing? |
As discussed in <#33 (comment)> ff. Suggested-by: Tobias Burnus <tobias@codesourcery.com>
This resolves #30 "[RFC] Handle sm_* which is no longer supported by CUDA / ptxas exec check or configure check?".
@vries, what do you think about this one? With that installed, we may then revert GCC commit bf4832d6fa817f66009f100a9cd68953062add7d "[nvptx] Fix ASM_SPEC workaround for sm_30", and GCC commit 12fa7641ceed9c9139e2ea7b62c11f3dc5b6f6f4 "[nvptx] Use --no-verify for sm_30".