Fixed binary permissions #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah chmod does nothing on Windows. For some silly reason, the Go language team decided to base their "cross platform" API on Linux-specific naming and the Unix model of filesystems (among other things). https://golang.org/src/os/file.go?s=15296:15340#L500 |
Southclaws
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #158
This fixes the issue with some binaries not having the correct permissions inside the archive, they are extracted from. My testing with Windows seems to have no effect on the permissions, so I left it out as a check, and only specifically targeted Linux/Mac.
I was able to successfully run the binaries after this change, so I can safely say this is fixed. Though this fix was not exactly described in the issue #158 I think it was related to it's use anyway.