Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 update python scripts to python3 #96

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

kranurag7
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: kranurag7 <anurag.kumar@syself.com>
Copy link

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python2 is no longer available by default on most distros, so we definitely don't want to build a dependency on old py2 in there.
I have not tested the code to work with py3, thus only a supporting comment, no approval.

@matofeder matofeder self-requested a review March 11, 2024 07:20
Copy link
Contributor

@michal-gubricky michal-gubricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested yet.

@chess-knight chess-knight marked this pull request as ready for review March 28, 2024 07:36
@cluster-stack-bot cluster-stack-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/hack Changes made in the hack directory labels Mar 28, 2024
@chess-knight chess-knight merged commit ab93fe5 into main Mar 28, 2024
4 checks passed
@chess-knight chess-knight deleted the kr/udpate-python-to-python3 branch March 28, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hack Changes made in the hack directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants