Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update build workflow #129

Merged
merged 1 commit into from
May 25, 2024
Merged

🌱 update build workflow #129

merged 1 commit into from
May 25, 2024

Conversation

kranurag7
Copy link
Contributor

update build workflow

we had a check for build but that was triggering when we merged a PR on
main branch and I don't think that's useful. We still had failures even
after that check.

This commits adds the same check to pr-lint workflow and removes the
build workflow that runs when a PR gets merged into main branch.

The reason to run it as part of lint workflow was because we have go
installed as part of this workflow.

We now also run it before we lint the codebase, this makes sure that we
run the build first followed by linting the codebase.

we had a check for build but that was triggering when we merged a PR on
main branch and I don't think that's useful. We still had failures even
after that check.

This commits adds the same check to pr-lint workflow and removes the
build workflow that runs when a PR gets merged into main branch.

The reason to run it as part of lint workflow was because we have go
installed as part of this workflow.

We now also run it before we lint the codebase, this makes sure that we
run the build first followed by linting the codebase.

Signed-off-by: kranurag7 <anurag.kumar@syself.com>
Copy link
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see whether it solves its purpose ;)

@janiskemper janiskemper marked this pull request as ready for review May 24, 2024 19:21
@cluster-stack-bot cluster-stack-bot bot added the area/github Changes made in the github directory label May 24, 2024
@janiskemper
Copy link
Member

works haha

@kranurag7
Copy link
Contributor Author

I think it works, I'll proceed with merging this and solve linting issue in a separate patch.

@kranurag7 kranurag7 merged commit 743057f into main May 25, 2024
4 of 5 checks passed
@kranurag7 kranurag7 deleted the kr/update-build-actions branch May 25, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github Changes made in the github directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants