Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add Licenses #4

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Add Licenses #4

merged 5 commits into from
Dec 5, 2022

Conversation

maxwolfs
Copy link
Contributor

Signed-off-by: maxwolfs mail@maxwolfs.com

closes #3

Signed-off-by: maxwolfs <mail@maxwolfs.com>
@maxwolfs maxwolfs requested a review from fkr November 21, 2022 12:21
@itrich
Copy link
Contributor

itrich commented Nov 22, 2022

I recommend to not use the CC license for the code parts within this repository. Either we find a suitable software license (e.g. the same used by the Docsaurus project) or we add two licenses: one for creative content, one for code.

Signed-off-by: maxwolfs <mail@maxwolfs.com>
@maxwolfs maxwolfs changed the title Add CC-BY-SA-4.0 License Add Licenses Nov 22, 2022
@maxwolfs
Copy link
Contributor Author

I recommend to not use the CC license for the code parts within this repository. Either we find a suitable software license (e.g. the same used by the Docsaurus project) or we add two licenses: one for creative content, one for code.

You're totally right. I have corrected it.

@itrich
Copy link
Contributor

itrich commented Nov 22, 2022

I'm still struggling to find the best way of maintaining multiple license files within one repository. IMHO the best approach is the one suggested here (and quoted from the SPDX documentation): https://softwareengineering.stackexchange.com/a/371435

Thus, we should have one LICENSE file that makes it clear to visitors how the content of this repository is licensed. You can note something like

The content of this repository is published under multiple licenses.
All files within `docs` are licensed under [CC-BY-SA 4.0](LICENSE-CC-SA-BY.md). 
All source code is licensed under the [MIT](LICENSE-MIT.md) license.

SPDX-License-Identifier: MIT AND CC-BY-SA 4.0

And then add the unmodified license files as LICENSE-CC-BY-SA.md and LICENSE-MIT.md.

See also https://codeberg.org/Community-Square/pages/pulls/4 for reference and https://spdx.github.io/spdx-spec/using-SPDX-short-identifiers-in-source-files/#e4-representing-multiple-licenses.

Sidenote: We should find a consistent way of handling those cases within the community and apply this to ALL our repositories. This will become even more important as soon as we start to use @oss-review-toolkit.

Signed-off-by: maxwolfs <mail@maxwolfs.com>
@maxwolfs
Copy link
Contributor Author

maxwolfs commented Dec 5, 2022

@itrich

Good point. I have found this blog post by GitHub regarding the issue of multiple Licenses within one repository: LINK

I have also made an exmaple repository to see how it works which you can see here: LINK

As they have build a feature to find multiple licenses automatically, I would suggest to use it as it is easy to use. Nevertheless I added your proposed also to the Readme.md to be as declarative as possible.

@itrich
Copy link
Contributor

itrich commented Dec 5, 2022

@itrich

Good point. I have found this blog post by GitHub regarding the issue of multiple Licenses within one repository: LINK

I have also made an exmaple repository to see how it works which you can see here: LINK

As they have build a feature to find multiple licenses automatically, I would suggest to use it as it is easy to use. Nevertheless I added your proposed also to the Readme.md to be as declarative as possible.

This looks good! Thank you for letting me learn something new 😄

Copy link
Contributor

@itrich itrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please capitalize LICENSE-docs? My inner monk is dying 😂

Signed-off-by: Max Wolfs <mail@maxwolfs.com>
@maxwolfs
Copy link
Contributor Author

maxwolfs commented Dec 5, 2022

Can you please capitalize LICENSE-docs? My inner monk is dying 😂

You are right, I have totally forgotten :D

@maxwolfs maxwolfs requested a review from itrich December 5, 2022 09:05
@maxwolfs maxwolfs merged commit 49c1355 into main Dec 5, 2022
@maxwolfs maxwolfs deleted the add-license branch December 5, 2022 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LICENSE info is missing
2 participants