Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add logging #25

Merged
merged 8 commits into from Apr 29, 2024
Merged

Feat/add logging #25

merged 8 commits into from Apr 29, 2024

Conversation

boekhorstb1
Copy link
Contributor

@boekhorstb1 boekhorstb1 commented Mar 4, 2024 •
edited

  • adding structlog to requirements.txt
  • added logging specific config to config.example.yaml
  • adding configuration of structlog in separate logger.py
  • initialisation takes place in __main__.py
  • added some calls to logger in various modules

see this issue #4

@boekhorstb1 boekhorstb1 self-assigned this Mar 4, 2024
@boekhorstb1 boekhorstb1 mentioned this pull request Mar 4, 2024
Closed
brueggemann
brueggemann reviewed Mar 6, 2024
View reviewed changes
src/rookify/__main__.py Outdated Show resolved Hide resolved
@boekhorstb1
feat: adding structlog to requirements.txt
66800b7 
Signed-off-by: Rafael te Boekhorst <boekhorst@b1-systems.de>
@boekhorstb1
feat: adding logger.py to configure structlog and then implemented it…
4e77789 
… in __main__.py and in the modules

Signed-off-by: Rafael te Boekhorst <boekhorst@b1-systems.de>
@boekhorstb1
fix: adapt example to have corret config path, add typing, add
da2fd91 
rudimentary makefile command to download config from testbed

Signed-off-by: Rafael te Boekhorst <boekhorst@b1-systems.de>
@boekhorstb1
fix: adding preliminary typing to MigrateMonitorsHandler
453dc16 
Signed-off-by: Rafael te Boekhorst <boekhorst@b1-systems.de>
@boekhorstb1
feat: add pre-commit command to run on all files
0d83869 
Signed-off-by: Rafael te Boekhorst <boekhorst@b1-systems.de>
@boekhorstb1
fix: add logger class to module handler
7d2283d 
Signed-off-by: Rafael te Boekhorst <boekhorst@b1-systems.de>
@boekhorstb1 boekhorstb1 marked this pull request as ready for review March 27, 2024 14:33
@NotTheEvilOne
Move logger initialization to main and keep Single Responsibility Pri…
150acf3 
…nciple

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
@NotTheEvilOne NotTheEvilOne self-assigned this Apr 28, 2024
@NotTheEvilOne
Add initial module execution log entry
8a8959e 
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
@brueggemann brueggemann merged commit 861d23a into main Apr 29, 2024
2 checks passed
@brueggemann brueggemann deleted the feat/add-logging branch April 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brueggemann brueggemann brueggemann approved these changes

@NotTheEvilOne NotTheEvilOne Awaiting requested review from NotTheEvilOne

Assignees

@NotTheEvilOne NotTheEvilOne

@boekhorstb1 boekhorstb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boekhorstb1 @brueggemann @NotTheEvilOne