Fix template #17
Merged
Fix template #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matofeder
added
bug
PR#15 introduced the feature: "Add a shorthand to jump to the history of the job." However, this did not work and broke the template, as the JobName property should be listed per Build. Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Zuul might generate a lengthy warning section embedded within the message. To prevent an excessively long title in the Matrix chat. This commit adds the `filterMessage` function that can be utilized within the template to isolate the message part. This function is then used in the default template. Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
chess-knight
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following:
filterMessagefunction that can be utilized within the template to isolate the message part. This function is then used in the default template.Note: The version with this fix (0.5.1-rc1) has been deployed to the SCS Zuul VM, so let's wait for some failed pipelines and check whether the fix is working as expected.