Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache key #46

Merged
merged 2 commits into from Aug 21, 2019
Merged

Remove cache key #46

merged 2 commits into from Aug 21, 2019

Conversation

gidsi
Copy link
Member

@gidsi gidsi commented Jun 30, 2019

The cache key is not used right now and the same function can already be achieved by using http header (e.g. Cache-Control)

Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree :)

Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a stylistic change request.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Danilo Bargen <mail@dbrgn.ch>
@gidsi gidsi requested a review from dbrgn June 30, 2019 21:01
@gidsi gidsi requested a review from rnestler July 1, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants