New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes issue report channel #47
Conversation
I agree. It might make sense if the issue report channel could be something different than the contact channel (e.g. |
It can refer to a different email address, that is the entire reason that there is Also @gidsi : {
"contact": {
"email": "foo@example.com"
},
"issue_report_channel": [
"issue_email",
"twitter"
]
} Is not valid. The entries in |
Ah, I wasn't aware that there's an |
The issue_mail has to be an email address and i would assume that the issue_report_channel was defined because someone wanted to have their issues reported by e.g. twitter. We don't need it at all since it's there to get "automated issue reports" which we currently don't provide. I didn't want to touch the |
As discussed offline: We'll remove the "contact": {
"email": {
"value": "info@shackspace.de",
"issue_report": true
}
} This removes the strange disconnection we currently have between the issue_report_channels and the contact fields. |
Right now the issue_report_channel is a bit weird:
E.g.
Which would be valid but obviously doesn't make any sense.
I would remove it since we don't use it anyways.