New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Home-Assistant app description #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I didn't take a look at the rendered version. Also is it possible to add a screenshot? Or some kind of image?
Sure, I'll add a screenshot later this evening or tomorrow! |
Sorry for the delay, totally forgot about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think that logo is fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌈 Thanks for the effort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
💩 I just realized that you merge author and space into one line like "By Fabian Affolter from Reaktor23." I'm not the author of the Home-Assistant integration (I just fixed some issues with it), but member of the Reaktor23 Hackerspace. What's your desired way of handling this? Remove the space and space_url? |
Ahh! The main idea is to put the author of the integration into those fields (if there is a main author). Who is that? If necessary, we can also adjust the model fields to become more flexible. |
Fabian Affolter is the original author, I'm not aware if he's member of a hackerspace A more flexible model would be nice, maybe something like a list of authors and their hackerspaces: Authors: |
Unfortunately I don't think Lektor supports that kind of flexibility for input fields. Would be nice though. In this case, I think you can simply remove the Reaktor 23 reference, and then we update the app views so that the space is only shown when a value is actually available. |
Maybe we should just make the author field it a free form string? |
It already is 🙂 |
Description for another app that serves SpaceAPI json