Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Home-Assistant app description #64

Merged
merged 3 commits into from Nov 28, 2019
Merged

Add Home-Assistant app description #64

merged 3 commits into from Nov 28, 2019

Conversation

Bouni
Copy link
Contributor

@Bouni Bouni commented Nov 15, 2019

Description for another app that serves SpaceAPI json

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I didn't take a look at the rendered version. Also is it possible to add a screenshot? Or some kind of image?

@Bouni
Copy link
Contributor Author

Bouni commented Nov 20, 2019

Sure, I'll add a screenshot later this evening or tomorrow!

@Bouni
Copy link
Contributor Author

Bouni commented Nov 26, 2019

Sorry for the delay, totally forgot about this.
There is no meaningful screenshot as Home-Assistant just serves the SpaceAPI JSON

Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think that logo is fine!

content/apps/homeassistant/contents.lr Outdated Show resolved Hide resolved
content/apps/homeassistant/contents.lr Show resolved Hide resolved
content/apps/homeassistant/contents.lr Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Bouni Bouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@rnestler rnestler requested a review from dbrgn November 27, 2019 22:42
Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌈 Thanks for the effort!

Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbrgn dbrgn merged commit ac0d025 into SpaceApi:master Nov 28, 2019
@Bouni
Copy link
Contributor Author

Bouni commented Nov 28, 2019

💩 I just realized that you merge author and space into one line like "By Fabian Affolter from Reaktor23."

I'm not the author of the Home-Assistant integration (I just fixed some issues with it), but member of the Reaktor23 Hackerspace.

What's your desired way of handling this? Remove the space and space_url?

@dbrgn
Copy link
Contributor

dbrgn commented Nov 28, 2019

Ahh! The main idea is to put the author of the integration into those fields (if there is a main author). Who is that?

If necessary, we can also adjust the model fields to become more flexible.

@Bouni
Copy link
Contributor Author

Bouni commented Nov 28, 2019

Fabian Affolter is the original author, I'm not aware if he's member of a hackerspace

A more flexible model would be nice, maybe something like a list of authors and their hackerspaces:

Authors:
Fabian Affolter
Bouni from Reaktor 23 Hackerspace

@dbrgn
Copy link
Contributor

dbrgn commented Nov 28, 2019

Unfortunately I don't think Lektor supports that kind of flexibility for input fields. Would be nice though.

In this case, I think you can simply remove the Reaktor 23 reference, and then we update the app views so that the space is only shown when a value is actually available.

@rnestler
Copy link
Member

Maybe we should just make the author field it a free form string?

@dbrgn
Copy link
Contributor

dbrgn commented Nov 28, 2019

It already is 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants