fix: special characters breaking image preview. Closes #492

SpaceCowMedia · May 29, 2024 · 2cf1d57 · 2cf1d57
1 parent 40cc144
commit 2cf1d57
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/layout/CardTooltip/CardTooltip.tsx b/src/components/layout/CardTooltip/CardTooltip.tsx
@@ -7,7 +7,7 @@ type Props = {
 };
 
 const CardTooltip = ({ cardName, children }: Props) => {
-  const url = cardName ? `https://api.scryfall.com/cards/named?format=image&version=normal&exact=${cardName}` : "";
+  const url = cardName ? `https://api.scryfall.com/cards/named?format=image&version=normal&exact=${encodeURIComponent(cardName)}` : "";
 
   const divRef = useRef<HTMLDivElement>(null);
 

diff --git a/src/pages/combo/[id]/index.tsx b/src/pages/combo/[id]/index.tsx
@@ -41,8 +41,8 @@ const Combo = ({ combo, alternatives }: Props) => {
     const cards = combo.uses.map((card) => {
       return {
         name: card.card.name,
-        artUrl: `https://api.scryfall.com/cards/named?format=image&version=art_crop&exact=${card.card.name}`,
-        oracleImageUrl: `https://api.scryfall.com/cards/named?format=image&version=normal&exact=${card.card.name}`,
+        artUrl: `https://api.scryfall.com/cards/named?format=image&version=art_crop&exact=${encodeURIComponent(card.card.name)}`,
+        oracleImageUrl: `https://api.scryfall.com/cards/named?format=image&version=normal&exact=${encodeURIComponent(card.card.name)}`,
       };
     });
     const cardNames = combo.uses.map(card => card.card.name);