This repository has been archived by the owner on Nov 15, 2018. It is now read-only.
Added separate built-in permission node for PlayerInteractEvent #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nvm, duplicate |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had the issue that my players weren't able to interact with signs/buttons/etc on my lobby server because of the built-in node "permissions.build". The said node cancels the PlayerInteractEvent.
I got several plugins (not my own) which are using "(ignoreCancelled = true, priority = EventPriority.HIGH)" above the PlayerInteractEvent. Here starts the mess... The event in the plugin is never been fired because of that and unfortunately I'm not allowed to edit the source (license restrictions). Tried to contact the developers but they don't seem to care that much.
The additional built-in node would make it a lot easier.
I would totally understand if this is not getting accepted because it's a "huge" change even if it's only one line of code.