Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for L?[x] list access syntax #262

Merged
merged 2 commits into from Apr 22, 2021

Conversation

willox
Copy link
Contributor

@willox willox commented Mar 25, 2021

I renamed the current IndexKind enum to PropertyAccessKind purely based off of the fact that somewhere in the byond ref both procs and vars are referred to as a datum's "properties" and I had no better name ideas.

The checker treats conditional list accesses exactly the same as normal ones. I was going to add some linting stuff for them but their expected behaviour is completely up in the air at the moment (see http://www.byond.com/forum/post/2667247.)

@SpaceManiac
Copy link
Owner

The BYOND forum link in your comment is broken, do you have another reference?

@willox
Copy link
Contributor Author

willox commented Apr 22, 2021

It was a bug report showing how a bunch of stuff compiled incorrectly in the current stable/beta branches. Lummox is still changing ?. in every single patch it seems so it's hard to decide on what is an error case atm.

It was merged into a similar thread but I can't find it.

@SpaceManiac SpaceManiac merged commit 9c75634 into SpaceManiac:master Apr 22, 2021
@SpaceManiac SpaceManiac added this to the suite v1.7 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants