Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrlp does not work. #1081

Closed
fabiogibson opened this issue Dec 6, 2017 · 2 comments
Closed

Ctrlp does not work. #1081

fabiogibson opened this issue Dec 6, 2017 · 2 comments
Milestone

Comments

@fabiogibson
Copy link

Expected behavior

Expect to be able to use CtrlP with ag searcher.

Environment Information

  • OS: Arch
  • vim version: 8.0
  • shell: zsh

The reproduce ways from Vim starting (Required!)

CtrlP with ag searcher does not execute.

Output of the ':echo g:ctrlp_user_command'

ag --hidden -i -g "" --ignore /tmp/ --ignore *.so --ignore *.swp --ignore *.zip --ignore *.class --ignore tags --ignore *.jpg --ignore *.ttf --ignore *.TTF --ignore *.png --ignore /target/ --ignore .git --ign\nore .svn --ignore .hg --ignore .DS_Store --ignore *.svg %s

Executing this command replacing %s for any valid pattern throws the following:

zsh: no matches found: /tmp/

My system requires the patterns to be enclosed in quotes:

Ex: --ignore '*.sp'.

I've fixed this replacing the line 280 at /autoload/zvim/util.vim

from:

call add(ignore, ig)

to:

call add(ignore, "'" . ig . "'")

Please let me know if a PR is welcome.

@fabiogibson fabiogibson changed the title Ctrlp does not work in my system. Ctrlp does not work. Dec 6, 2017
@wsdjeg
Copy link
Member

wsdjeg commented Dec 6, 2017

@fabiogibson Nice catch, there is old issue talk about ctrlp, but that only fix rg support, and your patch I think will fix ag support, PR welcome, and I will test it in bash.

@fabiogibson
Copy link
Author

Fixed #1082

@wsdjeg wsdjeg added this to the v0.6.0 milestone Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants