New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NeoSolarized guide theme #1187

Merged
merged 1 commit into from Dec 27, 2017

Conversation

Projects
None yet
2 participants
@thawk
Contributor

thawk commented Dec 27, 2017

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Add NeoSolarized statusline theme

Migrate solarized statusline/tabline theme to NeoSolarized, compatibly with terminal and GUI, dark and light background.

@wafflebot wafflebot bot added the WIP label Dec 27, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 27, 2017

Member

Hi, is it same as solarized? if it is you can use

function! SpaceVim#mapping#guide#theme#NeoSolarized#palette() abort
  return SpaceVim#mapping#guide#theme#Solarized#palette()
endfunction
Member

wsdjeg commented Dec 27, 2017

Hi, is it same as solarized? if it is you can use

function! SpaceVim#mapping#guide#theme#NeoSolarized#palette() abort
  return SpaceVim#mapping#guide#theme#Solarized#palette()
endfunction
@thawk

This comment has been minimized.

Show comment
Hide comment
@thawk

thawk Dec 27, 2017

Contributor

Yes,it's the same. I will update it.

Contributor

thawk commented Dec 27, 2017

Yes,it's the same. I will update it.

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 27, 2017

Member

@thawk Thanks

Member

wsdjeg commented Dec 27, 2017

@thawk Thanks

@wsdjeg wsdjeg merged commit 1ea5faf into SpaceVim:dev Dec 27, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot added Fixed and removed WIP labels Dec 27, 2017

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 27, 2017

Member

ohh, sorry, I merged it before you squash commits. 😟

Member

wsdjeg commented Dec 27, 2017

ohh, sorry, I merged it before you squash commits. 😟

@thawk thawk deleted the thawk:neosolarized_status_line branch Dec 27, 2017

@thawk

This comment has been minimized.

Show comment
Hide comment
@thawk

thawk Dec 27, 2017

Contributor

Should I create another PR to fix that?

Contributor

thawk commented Dec 27, 2017

Should I create another PR to fix that?

@wsdjeg

This comment has been minimized.

Show comment
Hide comment
@wsdjeg

wsdjeg Dec 27, 2017

Member

No, I it has been fixed, your commits has been merged. thanks for your PR.

Member

wsdjeg commented Dec 27, 2017

No, I it has been fixed, your commits has been merged. thanks for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment