Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkers layer #1364

Merged
merged 2 commits into from Feb 2, 2018
Merged

Fix checkers layer #1364

merged 2 commits into from Feb 2, 2018

Conversation

sei40kr
Copy link
Contributor

@sei40kr sei40kr commented Feb 1, 2018

PR Prelude

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

Fix an issue layer option show_cursor_error won't work. Show error
message in command line if show_cursor_error is off. Show warning
message if show_cursor_error were set to on without timer feature.

Fix an issue layer option show_cursor_error won't work. Show error
message in command line if show_cursor_error is off. Show warning
message if show_cursor_error were set to on without timer feature.
@sei40kr sei40kr requested a review from wsdjeg as a code owner February 1, 2018 14:28
@ghost ghost assigned sei40kr Feb 1, 2018
@ghost ghost added the WIP Work In Progress label Feb 1, 2018
@sei40kr sei40kr changed the title Fix checkers layer WIP: Fix checkers layer Feb 1, 2018
wsdjeg
wsdjeg previously approved these changes Feb 1, 2018
Fix typo: timer -> timers.
@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #1364 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
+ Coverage    31.3%   31.31%   +<.01%     
==========================================
  Files         239      239              
  Lines       11117    11121       +4     
==========================================
+ Hits         3480     3482       +2     
- Misses       7637     7639       +2

@sei40kr sei40kr changed the title WIP: Fix checkers layer Fix checkers layer Feb 1, 2018
@sei40kr sei40kr mentioned this pull request Feb 1, 2018
4 tasks
@sei40kr sei40kr merged commit dba60a3 into master Feb 2, 2018
@ghost ghost added Fixed and removed WIP Work In Progress labels Feb 2, 2018
@wsdjeg wsdjeg deleted the fix-neomake-fix branch February 2, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants