Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move [SPC]iu from edit layer to unite layer, and add the same mapping… #3169

Merged
merged 1 commit into from Oct 20, 2019

Conversation

thawk
Copy link
Contributor

@thawk thawk commented Oct 19, 2019

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I understand my PR may be closed if it becomes obvious I didn't actually perform all of these steps.

Why this change is necessary and useful?

fix #3150
But I just found you had fix that by #3168? If so, this PR can be abandoned.

[Please explain in detail why the changes in this PR are needed.]

@wsdjeg
Copy link
Member

wsdjeg commented Oct 20, 2019

the denite support has not be done in my PR. and maybe we should use a repo for unicode which can be used in other fuzzy layer.

@thawk
Copy link
Contributor Author

thawk commented Oct 20, 2019

Yes, I agree that. In my PR for Denite-sources, just 2 files are new, others are duplicated from Unite-sources. This don't conform the DRY principle. Have a standalone plugin is a better solution. And I think we can add more, like lookup the name for the current charater, to that plugin.

@wsdjeg
Copy link
Member

wsdjeg commented Oct 20, 2019 via email

@thawk
Copy link
Contributor Author

thawk commented Oct 20, 2019

It sounds good. But I don't know whether it's suitable to put these Unicode files into SpaceVim.

@wsdjeg
Copy link
Member

wsdjeg commented Oct 20, 2019

no, unicode.vim should be able used without spacevim.

@wsdjeg
Copy link
Member

wsdjeg commented Oct 20, 2019

just think about the fuzzy layer, we should merge source into one repo.

@wsdjeg wsdjeg merged commit e67a3b8 into SpaceVim:master Oct 20, 2019
@thawk
Copy link
Contributor Author

thawk commented Oct 20, 2019

I agrees to create a unicode plugin.

@thawk thawk deleted the dev branch October 20, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants