Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vimproc.vim bundle to latest version #3587

Merged
merged 1 commit into from Jun 26, 2020

Conversation

earthday
Copy link
Contributor

@earthday earthday commented Jun 24, 2020

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I understand my PR may be closed if it becomes obvious I didn't actually perform all of these steps.

Why this change is necessary and useful?

vimproc.vim fixed one issue about .gitignore file, so update it to avoid an error for vimproc library missing.

image

The following output is when I run make manually.

$ make
make -f make_unix.mak
make[1]: Entering directory '/home/bright/.SpaceVim/bundle/vimproc.vim'
cc -W -O2 -Wall -Wno-unused -Wno-unused-parameter -std=gnu99 -pedantic -shared -fPIC  -o lib/vimproc_linux64.so src/proc.c -lutil
/usr/bin/ld: cannot open output file lib/vimproc_linux64.so: No such file or directory
collect2: error: ld returned 1 exit status
make[1]: *** [make_unix.mak:17: lib/vimproc_linux64.so] Error 1
make[1]: Leaving directory '/home/bright/.SpaceVim/bundle/vimproc.vim'
make: *** [Makefile:66: all] Error 2

The root reason is that when running make, the folder lib does not exist, so it will be failed. The original repo fixed this issue as Shougo/vimproc.vim#302.

So that's why I update it to the latest.

vimproc.vim fixed one issue about .gitignore file, so update it to avoid
an error for vimproc library missing.

The root reason is that when running `make`, the folder lib does not
exist, so it will be failed.

Following output is when I run `make` mannually.

```
$ make
make -f make_unix.mak
make[1]: Entering directory '/home/bright/.SpaceVim/bundle/vimproc.vim'
cc -W -O2 -Wall -Wno-unused -Wno-unused-parameter -std=gnu99 -pedantic -shared -fPIC  -o lib/vimproc_linux64.so src/proc.c -lutil
/usr/bin/ld: cannot open output file lib/vimproc_linux64.so: No such file or directory
collect2: error: ld returned 1 exit status
make[1]: *** [make_unix.mak:17: lib/vimproc_linux64.so] Error 1
make[1]: Leaving directory '/home/bright/.SpaceVim/bundle/vimproc.vim'
make: *** [Makefile:66: all] Error 2
```
@wsdjeg wsdjeg merged commit d0b07bb into SpaceVim:master Jun 26, 2020
@wsdjeg
Copy link
Member

wsdjeg commented Jun 26, 2020

merged, thanks.

@earthday earthday deleted the update_vimproc_bundle branch June 28, 2020 05:58
adelin-b pushed a commit to adelin-b/SpaceVim that referenced this pull request Oct 25, 2020
vimproc.vim fixed one issue about .gitignore file, so update it to avoid
an error for vimproc library missing.

The root reason is that when running `make`, the folder lib does not
exist, so it will be failed.

Following output is when I run `make` mannually.

```
$ make
make -f make_unix.mak
make[1]: Entering directory '/home/bright/.SpaceVim/bundle/vimproc.vim'
cc -W -O2 -Wall -Wno-unused -Wno-unused-parameter -std=gnu99 -pedantic -shared -fPIC  -o lib/vimproc_linux64.so src/proc.c -lutil
/usr/bin/ld: cannot open output file lib/vimproc_linux64.so: No such file or directory
collect2: error: ld returned 1 exit status
make[1]: *** [make_unix.mak:17: lib/vimproc_linux64.so] Error 1
make[1]: Leaving directory '/home/bright/.SpaceVim/bundle/vimproc.vim'
make: *** [Makefile:66: all] Error 2
```

Co-authored-by: Bright Chen <bright.chen@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants