Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random theme functionality of the [colorscheme] layer #4204

Merged
merged 2 commits into from Apr 13, 2021
Merged

Fix random theme functionality of the [colorscheme] layer #4204

merged 2 commits into from Apr 13, 2021

Conversation

xudon9
Copy link
Contributor

@xudon9 xudon9 commented Apr 13, 2021

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I understand my PR may be closed if it becomes obvious I didn't actually perform all of these steps.

Why this change is necessary and useful?

[Please explain in detail why the changes in this PR are needed.]

The random colorscheme functionality, uses a JSON key "frequency" according to Documentation.
However, in

\ ctime - get(conf, 'last', 0) >= get(s:time, get(conf, 'fequecnce', ''), 0)
and in
\ 'fequecnce' : s:random_frequency,

frequency or frequence is misspelled as fequecnce, causing the customized frequency not working.

And I noticed some inconsistency of using both "frequency" and "frequence", which is error-prone.

I fixed its functionality by changing all of them to "frequency".

@wsdjeg wsdjeg merged commit d13cf32 into SpaceVim:master Apr 13, 2021
@wsdjeg
Copy link
Member

wsdjeg commented Apr 13, 2021

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants