Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotation marks on press page replaced by strange characters #233

Closed
alicetragedy opened this issue Feb 5, 2016 · 8 comments · Fixed by #238
Closed

Quotation marks on press page replaced by strange characters #233

alicetragedy opened this issue Feb 5, 2016 · 8 comments · Fixed by #238
Labels

Comments

@alicetragedy
Copy link

I came across the website (love the project!) and noticed a strange thing on the press page: the quotation marks are replaced by a â. I've attached a screenshot (you can see the characters as well as part of my web inspector) below and I believe it might have to do with this bit in the css, however I didn't run it locally so I haven't been able to double-check if simply removing those few declarations fixes the problem. Would be happy to help further!

screen shot 2016-02-05 at 22 14 56

@jaylett
Copy link
Member

jaylett commented Feb 6, 2016

Thanks for reporting this — I believe the problem is a character set issue while building the CSS. @georgebrock may know more. I agree in the short term we should remove the quotation marks as you suggest, while we figure out how to make them work properly again.

@alicetragedy
Copy link
Author

👍
feel free to ping me if you need me to test anything or want some help :)

@JPinSPACE
Copy link

I was going to make a new issue for this but I bet it's related. Check out the â| symbols by the CAPCOM on this page: http://apollo13.spacelog.org/04:06:11:57/#log-line-367917

@jaylett
Copy link
Member

jaylett commented Feb 9, 2016

@JPinSPACE it looks like the same problem to me (getting the encoding wrong when we generate the CSS file). Thanks for noting that!

@georgebrock
Copy link
Member

We think switching from the Ruby implementation of Sass to the Python bindings for libsass will help.

This worked locally for @jaylett, but is missing development mode live updating: https://gist.github.com/jaylett/b7a5fea55d065fa96afa

@norm
Copy link
Member

norm commented Feb 16, 2016

I've previously used https://gist.github.com/norm/271bf72f77ae9df0fd9e — "Minimum Viable Python-only automatic SASS compilation"

@jaylett
Copy link
Member

jaylett commented Dec 29, 2016

#238 hasn't been deployed yet, so this is still an open issue.

@jaylett jaylett reopened this Dec 29, 2016
@georgebrock
Copy link
Member

We've switched over to a new server, and fixed this in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants