Django upgrades #255
Merged
Django upgrades #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes were required for compatibility: - Use format_html with simple_tag for Django 1.9 cf. https://docs.djangoproject.com/en/1.11/releases/1.9/#simple-tag-now-wraps-tag-output-in-conditional-escape - Remove templatetag_sugar for Django 1.9 The latest version of templatetag_sugar isn't compatible with Django after version 1.8. - Use relative imports. It looks like the default load path changed in Django 1.9 -- it was no longer possible to load these modules from the global module using their name relative to the website module.
Some changes were required for comaptibility: - URL config has changed: we can no longer pass strings instead of callables, and `patterns` has been removed. - `django.core.context_processors` is has become `django.template.context_processors` - `render_to_response` and `render_to_string` no longer take a context instance. In places where this wasn't important, the parameter has been removed. In places where the template needs a reference to the request (e.g. for the current mission) the views have been converted to generic CBVs.
georgebrock
force-pushed
the
django-upgrades
branch
from
e52f2d8
to
a6d703d
Compare
Confusingly, there are two types of Template. There's the engine-specific version (django.templates.backends.django.Template) and the generic version (djangot.templates.base.Template). The engine-specific template composes a generic template. The production code was expecting an engine-specific template, but the test was using a generic template.
Template context must be a dict instead of a context instance now, so a test needed changing.
|
Everything appears to be working on Django 1.11. This is no longer work in progress. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress: given how infrequently we get around to the major upgrades, I don't want to merge it until we get to 1.11, which it the next LTS release after 1.8.
The upgrade was motivated by #254 (more notes over there).