cleanup #123
cleanup #123
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello Contributor,👋👋 Thank You For Opening This Pull Request 🎉🎉
Welcome to SpaceYaTech
We are the fastest growing Africa Open-Source Community Looking To Change The Way Young Africans Get Started In Technology.
JOIN US | THRIVE | GROW
It's great having you contribute to this project
Welcome to the community 🤓 🍿 **Fun facts** - we eat bugs 🐛🐛🐛🐛 for breakfast 🥣This Pull request has been queued for `review`
Sit tight the maintainers are on your case.Soon the maintainers/owner will review it and provide you with feedback suggestions.
If you think it's something urgent, feel free to reach out
There was a problem hiding this comment.
On the env argument or parameter, is that a windows is devs thing? I’d suggest using decouple and using config instead
CMS/settings.py
Outdated
| @@ -182,8 +180,8 @@ | |||
| } | |||
|
|
|||
| SIMPLE_JWT = { | |||
| 'ACCESS_TOKEN_LIFETIME': timedelta(minutes=5), | |||
| 'REFRESH_TOKEN_LIFETIME': timedelta(days=90), | |||
| 'ACCESS_TOKEN_LIFETIME': timedelta(minutes=60), | |||
| router = routers.DefaultRouter() | ||
| router.register('blog',StoriViewset,basename="blog" ) | ||
| router.register('blogs', StoriViewset, basename="blogs") |
There was a problem hiding this comment.
Well need to have consistent names for our routes, models and views
There was a problem hiding this comment.
Yeah. Either posts, blogs or stori or mastori
| self.permission_classes = [IsAdminUser] | ||
| # anyone can create, retrieve and list all categories | ||
| elif self.action == 'retrieve' or self.action == "create" or self.action == "list": | ||
| self.permission_classes = [AllowAny] |
There was a problem hiding this comment.
We'll need to include permisions that only allow account owners to list their accounts
- Restrict only acount owners and admins to list accounts
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist: