Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Poetry config files for improved dependency management #153

Conversation

tony-nyagah
Copy link

Description

Added a pyproject.tml file using Poetry to the project. The file contains all the current project dependencies but using Poetry enables better management of dependencies preventing issues with circular dependency and invalid dependencies.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

CI Django & Postgres Tests

Jambo

Test Configuration:

          python manage.py migrate
          python manage.py test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Contributor,👋👋 Thank You For Opening This Pull Request 🎉🎉

Welcome to SpaceYaTech

We are the fastest growing Africa Open-Source Community Looking To Change The Way Young Africans Get Started In Technology.

JOIN US | THRIVE | GROW

SpaceYaTech Server
SpaceYaTech LinkedIn
SpaceYaTech Twitter
Website

It's great having you contribute to this project

Welcome to the community 🤓 🍿 **Fun facts** - we eat bugs 🐛🐛🐛🐛 for breakfast 🥣

This Pull request has been queued for `review`

Sit tight the maintainers are on your case.

Soon the maintainers/owner will review it and provide you with feedback suggestions.
If you think it's something urgent, feel free to reach out

@Gibson-Gichuru
Copy link
Contributor

Awesome!
NIT: you can remove black from the production dependencies listing.

Copy link
Contributor

@Gibson-Gichuru Gibson-Gichuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker images need to be updated to cater for the new dependency management

- this fixes failing docker pipelines
@tony-nyagah
Copy link
Author

@Gibson-Gichuru I updated the requirements file. Exported the requirements from the pyproject.toml file. This should fix the error with the workflows.

@Gibson-Gichuru
Copy link
Contributor

@Gibson-Gichuru I updated the requirements file. Exported the requirements from the pyproject.toml file. This should fix the error with the workflows.

I mean the docker file still uses the old requirements.txt to build the application. should now be using the .tml file

@tony-nyagah
Copy link
Author

@Gibson-Gichuru I updated the requirements file. Exported the requirements from the pyproject.toml file. This should fix the error with the workflows.

I mean the docker file still uses the old requirements.txt to build the application. should now be using the .tml file

This means the project is moving away from using the requirements.txt file to Poetry and the pyproject.toml file right?
I had assumed this issue was for keeping the requirements.txt file well updated.

Copy link
Member

@JimmyTron JimmyTron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using Pipenv

@aibunny
Copy link
Contributor

aibunny commented Dec 9, 2023

let's use pipenv for uniformity across all our python projects

@tony-nyagah
Copy link
Author

let's use pipenv for uniformity across all our python projects

Let me create an issue and get working on it.

Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants