-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ⌘A shortcut to select text on macOS (fix issue #319) #415
Enable ⌘A shortcut to select text on macOS (fix issue #319) #415
Conversation
- Makes "Select All" appear in the "Edit" menu. - In macOS, this must be present for the ⌘A shortcut to work. - Fixes issue SpacingBat3#319
I've actually looked at #319 and I believe lack of select all in Edit menu is done on purpose, it's not just the macOS missing the select all but all platforms does. I think I did this as I was aware of it selecting the whole page (not just the selected input box content) and I rarely use that functionality in any of the applications (a lot of people actually don't by looking how many requests this – and I'm personally used to clicking on the text three times in the row), so I had no intentions to bringing it back. At this rate, it's more like a feature request, not a bug 😛️… And I'm not sure whenever I want to accept feature requests in I'll leave this open for a while and rethink about it. |
Regardless of whether you consider it a niche use-case or don't personally require it, the shortcut is one I use frequently enough that its absence is surprising and frustrating; I don't like switching to my mouse while editing text, and not everyone uses a mouse. Insofar as Ctrl+A is a feature that exists in all official versions of the Discord client (and every text field in every websites and applications on my system), breaking that feature in this client is a bug or a regression by any reasonable definition. I'm not sure why Electron gives app-developers the option to break parts of the web platform (let alone have them broken out of the box), but assuming you want Webcord to have basic feature parity with Discord's web client, you absolutely shouldn't do that. |
I won't merge this, |
Also, a fix should take place before next release and I plan to update WebCord quite soon, probably after I deal with updating some of its dependencies to claim newer Node.js support and (in case of ReForged) implement some new features (WebCord is not the only repo that affects the client's final code and features). |
Howdy, just figured I'd re-open this PR (rebased copy of #373) in case you're doing more minor patches on the v4 branch. I want to use WebCord as my primary Discord client, but I can't without this bug being fixed.