Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted: Add capture limit to map config #34

Closed
Haxk20 opened this issue Oct 25, 2022 · 2 comments
Closed

Help wanted: Add capture limit to map config #34

Haxk20 opened this issue Oct 25, 2022 · 2 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@Haxk20
Copy link
Contributor

Haxk20 commented Oct 25, 2022

This is a very good first contributor issue for someone.

Capture limit has to be per map and thus map needs to have a capture limit
in the config.
This will require a new variable in structs.
Loading and using it should be very easy otherwise.

@Haxk20 Haxk20 added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest labels Oct 25, 2022
@lokka30
Copy link
Contributor

lokka30 commented Nov 9, 2022

@Haxk20, is this config layout suitable for this?

"capture-limits": {
        "default": 10,
        "Border_Hallway": 10
},

@Haxk20
Copy link
Contributor Author

Haxk20 commented Nov 9, 2022

@Haxk20, is this config layout suitable for this?

"capture-limits": {
        "default": 10,
        "Border_Hallway": 10
},

This should be in map config and default specified in the macros

utf-4096 added a commit to utf-4096/SpadesX-1 that referenced this issue May 6, 2023
Configurable in config.json and in map config.

Closes SpadesX#34
@Haxk20 Haxk20 closed this as completed in a592876 May 6, 2023
lokka30 pushed a commit to lokka30/SpadesX that referenced this issue Feb 15, 2024
Configurable in config.json and in map config.

Closes SpadesX#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants