Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrect unenclosed strings and lists #217

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

mc-oofert
Copy link
Contributor

@mc-oofert mc-oofert commented Jul 30, 2023

Description

If the user tries to change a variable to stuff like
list(hi
"im a string
it automatically corrects to
list(hi)
"im a string"

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Open up a messagebox and warn the user and revert their variable change if they do a string like "hi
(which causes load errors)
@SpaiR SpaiR added enhancement New feature or request go Pull requests that update Go code labels Jul 30, 2023
internal/app/ui/cpvareditor/vareditor.go Outdated Show resolved Hide resolved
internal/app/ui/cpvareditor/vareditor.go Outdated Show resolved Hide resolved
@SpaiR
Copy link
Owner

SpaiR commented Jul 30, 2023

As a thought: maybe it's better to auto-correct a mistake?

@mc-oofert
Copy link
Contributor Author

As a thought: maybe it's better to auto-correct a mistake?

gonna try that once i finish up on the screenshot pr

@mc-oofert
Copy link
Contributor Author

As a thought: maybe it's better to auto-correct a mistake?

did

@mc-oofert mc-oofert changed the title Disallow unenclosed strings and lists Autocorrect unenclosed strings and lists Jul 30, 2023
@SpaiR SpaiR merged commit 82b5a28 into SpaiR:main Jul 31, 2023
5 checks passed
@SpaiR SpaiR added tweak Small changes or improvements and removed enhancement New feature or request labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code tweak Small changes or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants