Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python-future for 2 and 3 Python compatibility #46

Closed
alexkiro opened this issue Dec 15, 2015 · 2 comments
Closed

Use python-future for 2 and 3 Python compatibility #46

alexkiro opened this issue Dec 15, 2015 · 2 comments
Assignees
@GabiSL
Labels
enhancement Pyzor Client Pyzor Server Testing
Milestone
1.1

Comments

@alexkiro
Copy link
Contributor

Right now the Pyzor code is compatible with both Python 2 and Python 3 but only if the the code is converted with 2to3 first. When installing using pip this is done automatically, however it would be better to just use python-future for this and so no conversion will be required.
@alexkiro alexkiro mentioned this issue Dec 15, 2015
Closed
@alexkiro alexkiro modified the milestone: 1.1 Jan 6, 2016
@alexkiro alexkiro self-assigned this Jan 15, 2016
alexkiro added a commit that referenced this issue Jan 15, 2016
@alexkiro
Refs. #46. Bump requirements version.
0328fb0 
Switch to using `mysqlclient` instead of `MySQL-python`
because that has support for Python3 as well. Adjust the
run tests script to also handle MariaDB installations
instead of MySQL.
alexkiro added a commit that referenced this issue Jan 15, 2016
@alexkiro
Refs. #46. Fix all unitest for Python3.
7afe0ae 
Adjust all the unittest and code to pass on  Python3
without any 2to3 conversion (even without the
python-future library installed).
alexkiro added a commit that referenced this issue Jan 15, 2016
@alexkiro
Refs. #46. Fix all functional tests for Python3.
785541b 
Adjust all the functional and code to pass on  Python3
without any 2to3 conversion (even without the
python-future library installed!).
alexkiro added a commit that referenced this issue Jan 15, 2016
@alexkiro
Refs. #46. Remove the 2to3 conversion.
b908b38 
Remove from the setup script and the run_tests
helper script.
@alexkiro
Copy link
Contributor Author

Latest build is passing. FWIW python-future wasn't actually required.

@alexkiro alexkiro removed their assignment Jan 15, 2016
@GabiSL
Copy link
Contributor

GabiSL commented Jan 22, 2016

Verified - Passed!

@GabiSL GabiSL closed this as completed Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GabiSL GabiSL

Labels
enhancement Pyzor Client Pyzor Server Testing
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@alexkiro @GabiSL