DIG-21418 componentWillReceiveProps ftw - not change state in render

SpareBank1 · Mar 7, 2017 · d5a4a4f · d5a4a4f
1 parent 2c2990b
commit d5a4a4f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## v3.0.2
 
-* Fixed: When no children, or a falsy value, is passed as children to `TableRowExpandable` the row will set the expanded value in this.state to false. 
+* Fixed: When no children, or a falsy value, is passed as children to `TableRowExpandable` the row will set the expanded value in this.state to false in componentWillReceiveProps.
 
 ## v3.0.1
 

diff --git a/src/TableRowExpandable/TableRowExpandable.js b/src/TableRowExpandable/TableRowExpandable.js
@@ -25,14 +25,16 @@ class TableRowExpandable extends Component {
         }
     }
 
+    componentWillReceiveProps(newProps) {
+        if (!newProps.children && this.state.expanded) {
+            this.setState({ expanded: false });
+        }
+    }
+
     render() {
         const { cells, columns, children } = this.props;
         const unexpandable = !children;
 
-        if (unexpandable && this.state.expanded) {
-            this.setState({ expanded: false });
-        }
-
         return (
             <tbody>
                 <TableRow