You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some consumers would only like the SVGs and use them directly in their app. Today we force these users to download PhantomJS as part of svg-sprite. This is a requirement to generate an SVG sprite of multiple icons at build-time. However, not all consumers want or need this feature.
Proposed solution:
Create a new package ffe-icons-assets that only holds the SVGs
Release a version of ffe-icons that uses ffe-icons-assets as its source for SVGs. If it is set as a devDependency and the SVG assets are copied and bundled in the same place as before when publishing we can avoid a breaking change.
ffe-icons-react carries on, business as usual
This way we support these three use cases:
I use React
I don't use React and I just need one or two SVGs and don't want or need sprites
I don't use React and I need several SVGs and should probably bundle them in a sprite
The text was updated successfully, but these errors were encountered:
A breaking change was needed for ffe-icons and ffe-icons-react got a new major version as well. There were no changes in the API for the latter, only a new major due to the risk of visual regressions. But no more PhantomJS 🎉
Some consumers would only like the SVGs and use them directly in their app. Today we force these users to download PhantomJS as part of
svg-sprite
. This is a requirement to generate an SVG sprite of multiple icons at build-time. However, not all consumers want or need this feature.Proposed solution:
ffe-icons-assets
that only holds the SVGsffe-icons
that usesffe-icons-assets
as its source for SVGs. If it is set as a devDependency and the SVG assets are copied and bundled in the same place as before when publishing we can avoid a breaking change.ffe-icons-react
carries on, business as usualThis way we support these three use cases:
The text was updated successfully, but these errors were encountered: