Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum fix #2

Closed
wants to merge 3 commits into from
Closed

Minimum fix #2

wants to merge 3 commits into from

Conversation

thibaultduponchelle
Copy link

Hello,

This is a minimal set of fixes (without the refactoring like other PR) to fix https://rt.cpan.org/Ticket/Display.html?id=110739 and https://rt.cpan.org/Ticket/Display.html?id=102777.
It also comes with an include change, some commented tests and a MANIFEST.

What do you think about this ?

Best regards.

Thibault

Copy link

@BrianAker BrianAker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never want to use a non-version specific include file over a version specific. ( Never is a stretch... but it does harm forward ( and possibly ) backwards compatibility.

@thibaultduponchelle
Copy link
Author

Sorry, I made this because I noticed (can't reproduce now) a gearman.h that was just doing #include <libgearman-1.0/gearman.h> inside. And because I don't know well what I'm doing 😆

I updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants