This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
Support HSequential #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 1, 2016 18:11
This treats them just like HVecs except it adds a predicate that they satisfy sequential? It may be worth noting that the schema for HVec allows things not allows by the core.typed predicate, e.g. lists. Possibly it's worth revisiting these types with stronger type predicate schemas?
This requires the seq to be an instance of clojure.lang.LazySeq (which may be too strong, tbqh) and that it has a first value whose type checks the seq's type.
This seems to be a straightforward predicate
| '["hey" 12]))) | ||
| (is (nil? (s/check (schema (t/NonEmptyLazySeq t/Int)) (map inc (range))))) | ||
| (is (nil? (s/check (schema (t/HMap :absent-keys #{:foo :bar})) {:not "foo"}))) | ||
| (is (not (nil? (s/check (schema (t/HMap :absent-keys #{:foo :bar})) {:foo "foo"}))))) |
There was a problem hiding this comment.
just fyi: there is some? which I always forget about because I'm a pre-1.0-or-bust person :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSequential and HVec are just like HSeq except they add a predicate for sequential? and vector?, respectively. NonEmptyLazySeq uses both a predicate for instanceof LazySeq (slightly stronger than what core.typed does itself, but both appear to exclude e.g. (range) proper) and tests the first value in the seq against the type.