-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX-431 Align chevron in Page component breadcrumbs #746
Conversation
<StyledLink {...rest} fontSize="200" lineHeight="200" fontWeight="medium"> | ||
<Box as="span" display="inline-flex" align-items="center"> | ||
<ChevronLeft size={20} /> | ||
<StyledLink {...rest} fontSize="200" lineHeight="450" fontWeight="medium"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug here, UnstyledLink doesn't accept fontSize="200" lineHeight="450" fontWeight="medium"
at all, I don't see the styles being applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least here it doesn't seem like it works: https://matchbox-storybook.netlify.app/?path=/story/layout-page--basic-example
<Box as="span" display="inline-flex" align-items="center"> | ||
<ChevronLeft size={20} /> | ||
<StyledLink {...rest} fontSize="200" lineHeight="450" fontWeight="medium"> | ||
<Box as="span" display="inline-flex" align-items="center" lineHeight={tokens.spacing_450}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's weird is storybook is applying this lineHeight, but in the App, this lineHeight is missing, which is causing the misalignment.
Not really sure what the fix is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look here for an example: https://matchbox-storybook.netlify.app/?path=/story/layout-page--basic-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all we need to do is make align-items
-> alignItems
? But still not sure why the bug isn't happening locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified changes through chrome dev tools – should update alignItems
though
What Changed
Page
componentHow To Test or Verify
npm run start:storybook
PR Checklist
type
label