Merge pull request #202 from SparkPost/ignore-empty-sugar

added check around cc and test

CHANGELOG.md

@@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased][unreleased]
+### Fixed
+- Empty CC sugar method no longer triggers an API error.
 
 ## [2.1.0] - 2016-12-20
 ### Added

lib/transmissions.js

@@ -100,7 +100,7 @@ function formatPayload(originalTransmission) {
   });
 
   // add the CC headers
-  if (_.isArray(transmission.cc)) {
+  if (_.isArray(transmission.cc) && transmission.cc.length > 0) {
     _.set(transmission, 'content.headers.CC', generateCCHeader(transmission));
   }
 

test/spec/transmissions.spec.js

@@ -215,6 +215,31 @@ describe('Transmissions Library', function() {
         });
     });
 
+    it('should ignore empty bcc and cc', function() {
+      var transmission = {
+        recipients: [
+          {
+            address: {
+              name: "Bob",
+              email: "recipient1@gmail.com"
+            }
+          },
+        ],
+        cc: [],
+        bcc: [],
+        content: {
+          template_id: 'my-template-id'
+        }
+      };
+
+      return transmissions.send(transmission)
+        .then(function() {
+          delete transmission.cc;
+          delete transmission.bcc;
+
+          expect(client.post.firstCall.args[0].json).to.deep.equal(transmission);
+        });
+    });
 
     it('should convert cc to the correct recipients and headers', function() {
       return transmissions.send(ccTransmission)