Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body might be undefined #126

Closed
wants to merge 2 commits into from
Closed

body might be undefined #126

wants to merge 2 commits into from

Conversation

mstdokumaci
Copy link
Contributor

When body is undefined it throws exceptions.

When body is undefined it throws exceptions.
@aydrian
Copy link
Contributor

aydrian commented Mar 27, 2016

Thank you for your Pull Request. We will look it over as soon as we can.

@ewandennis
Copy link
Contributor

Hi @mstdokumaci. Many thanks for the PR. Would you mind opening an issue describing how you ran into this problem? It would also be great to see a matching test. We'll then use the issue and test to know if we have another fix underway which covers this issue.

@jasonrhodes
Copy link
Contributor

@mstdokumaci thanks for this PR -- looks good, just 2 quick things:

  1. Can you move the || check to the top of that else if block? Something like body = body || {}; just to make it more explicit what happened there.
  2. We'll need a test to cover this case. Are you comfortable adding one?

@aydrian
Copy link
Contributor

aydrian commented Apr 1, 2016

Thanks for the update, @mstdokumaci. If you can add a test, I can get this into today's 1.3.0 release.

@aydrian
Copy link
Contributor

aydrian commented Apr 1, 2016

I added the test and merged.

@aydrian aydrian closed this Apr 1, 2016
@aydrian aydrian added this to the 1.3.0 Release milestone Apr 1, 2016
@mstdokumaci mstdokumaci deleted the patch-1 branch April 3, 2016 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants