Updated bulk suppression list upsert payload. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +64,7 @@ module.exports = function(client) { | |||
| // Check for bulk upsert | |||
| if(recipient.constructor === Array) { | |||
| options.uri = api; | |||
| options.json = toApiFormat(recipient); | |||
| options.json = { recipients: toApiFormat(recipient) }; | |||
| } else if(!recipient.email) { | |||
There was a problem hiding this comment.
Single recipient upload isn't supported anymore, so this else block should just error out with the same error we were getting from the API. Alternatively it could insert the single value into an array.
|
The whole function should be updated to remove the old convention of single upsert (/suppressions/:email), which is no longer supported. Relevant examples and tests should be deleted. |
|
Okay. Let's add that as another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
For bulk upserts we needed to send a payload of an object with a recipients key. We were sending an array of recipients.