Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored subaccounts library #172

Merged
merged 6 commits into from
Sep 6, 2016

Conversation

aydrian
Copy link
Contributor

@aydrian aydrian commented Aug 31, 2016

Issue #156 Subaccounts

@aydrian aydrian added this to the 2.0.0 Release milestone Aug 31, 2016
@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 25b8ec9 on aydrian:issue-156-subaccounts into 1faf3fc on SparkPost:wip-2.0.0.

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 54a6ca7 on aydrian:issue-156-subaccounts into 1faf3fc on SparkPost:wip-2.0.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a6de860 on aydrian:issue-156-subaccounts into 1faf3fc on SparkPost:wip-2.0.0.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling a6de860 on aydrian:issue-156-subaccounts into 1faf3fc on SparkPost:wip-2.0.0.


## Methods
* **all(callback)**
* **list([callback]) &rarr; `{Promise}`**<br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting rid of both the [, callback] and the &rarr; {Promise} stuff in these lines because I like how the note at the top just covers all of the async cases for everything at once, then the docs are de-cluttered to just show the things that are important for that individual method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot. Missed that.

@aydrian aydrian merged commit b11ccff into SparkPost:wip-2.0.0 Sep 6, 2016
@aydrian aydrian deleted the issue-156-subaccounts branch September 6, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants