Add more useful details to the User-Agent header #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like just the documentation suggestion. And I'm guessing our reporting can handle the space separated values okay. |
aydrian
approved these changes
Nov 9, 2016
| createVersionStr = function(version, options) { | ||
| let versionStr = 'node-sparkpost/' + version + ' node.js/' + process.version; | ||
| if (options.stackIdentity) { | ||
| versionStr += options.stackIdentity + ' ' + versionStr; |
There was a problem hiding this comment.
If we are adding an option, it should be included somewhere in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Node.js version string and an optional "stack identifier" so we can track libs that use node-sparkpost such as nodemailer-sparkpost-transport.