Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tracking Domains api #242

Closed
wants to merge 3 commits into from
Closed

Add support for Tracking Domains api #242

wants to merge 3 commits into from

Conversation

optii
Copy link

@optii optii commented Jul 26, 2019

Hi,

This Pull Requests add support for the missing tracking domain API

Thanks,

@jgzamora jgzamora self-requested a review July 29, 2019 15:56
@jgzamora jgzamora self-assigned this Jul 29, 2019
Copy link
Contributor

@jgzamora jgzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

lib/trackingDomains.js Outdated Show resolved Hide resolved
test/spec/trackingDomain.spec.js Outdated Show resolved Hide resolved
@optii
Copy link
Author

optii commented Jul 30, 2019

Made the changes as suggested!

@optii
Copy link
Author

optii commented Aug 16, 2019

Following up on this, is there anything stopping this from being merged ?

@optii
Copy link
Author

optii commented Sep 27, 2019

Hi, just checking in on this, is there anything else needed for this to get merged ? Happy to do the necessary to get this through.

Thanks,

@optii optii closed this by deleting the head repository Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants